image/tree: Hide Content size column without containerd store#5771
Draft
vvoland wants to merge 1 commit intodocker:masterfrom
Draft
image/tree: Hide Content size column without containerd store#5771vvoland wants to merge 1 commit intodocker:masterfrom
vvoland wants to merge 1 commit intodocker:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5771 +/- ##
==========================================
- Coverage 59.20% 59.17% -0.04%
==========================================
Files 353 353
Lines 29522 29538 +16
==========================================
Hits 17478 17478
- Misses 11072 11088 +16
Partials 972 972 |
With graph drivers, all content sizes are zero because the compressed content isn't stored. This makes the whole column useless and wasting the terminal space. Hide the whole column if all its values would be zero. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
image-tree-contentsize
branch
from
8949711 to
203ce87
Compare
Benehiko
approved these changes
Feb 4, 2025
laurazard
approved these changes
Feb 6, 2025
Member
|
@vvoland did you want this merged soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With graph drivers, all content sizes are zero because the compressed content isn't stored.
This makes the whole column useless and wasting the terminal space.
Hide the whole column if all its values would be zero.
Before
After